joyhaldar commented on PR #15688: URL: https://github.com/apache/iceberg/pull/15688#issuecomment-4096787175
> > Removing `.engineSchema()` from `BaseFormatModelTests` will also break older Spark and Flink versions that don't have the fallback yet. Should I wait until backports are done? > > We can update all of the Spark and Flink versions in one PR, and then we can have a test where it is removed. > > Also, reflecting on @huaxingao’s comment, I think we should keep the other tests as well. Thank you Péter. I have applied the fallback to all Spark and Flink versions. I have also added new tests for the null engineSchema path while keeping existing tests that set it explicitly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
