pvary commented on code in PR #15688:
URL: https://github.com/apache/iceberg/pull/15688#discussion_r2964764804
##########
data/src/test/java/org/apache/iceberg/data/BaseFormatModelTests.java:
##########
@@ -140,6 +140,45 @@ void testDataWriterEngineWriteGenericRead(FileFormat
fileFormat, DataGenerator d
DataTestHelpers.assertEquals(schema.asStruct(), genericRecords,
readRecords);
}
+ @ParameterizedTest
+ @FieldSource("FORMAT_AND_GENERATOR")
+ /** Write with engine type T without explicit engineSchema, read with
Generic Record */
Review Comment:
The comments and annotations should be reordered so that this comment can be
treated as Javadoc.
```suggestion
/** Write with engine type T without explicit engineSchema, read with
Generic Record */
@ParameterizedTest
@FieldSource("FORMAT_AND_GENERATOR")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
