anoopj commented on code in PR #15049: URL: https://github.com/apache/iceberg/pull/15049#discussion_r2991941899
########## core/src/main/java/org/apache/iceberg/TrackedFile.java: ########## @@ -0,0 +1,173 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg; + +import java.nio.ByteBuffer; +import java.util.Collections; +import java.util.List; +import java.util.Set; +import org.apache.iceberg.stats.ContentStats; +import org.apache.iceberg.types.Types; + +/** A file tracked by a v4 manifest. */ +interface TrackedFile { + Types.NestedField TRACKING = Review Comment: The v4 manifest entry schema is intentionally flat rather than nesting a `DataFile` struct. A few reasons: 1. The fields aren't identical to `DataFile`: `TrackedFile` uses `location` instead of `file_path`, `content_type` includes manifest types , and stats are captured differently. 2. Our proposal defines the entry schema as a flat structure. 3. Tracking info (status, sequence numbers, snapshot IDs) applies to the entry as a whole, not just to the content file , so it naturally lives at the same level. The translation between TrackedFile and DataFile/DeleteFile for backwards compatibility is handled in the read/write paths. I am planning to implement an adapter layer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
