jacobsalway commented on code in PR #15530:
URL: https://github.com/apache/iceberg/pull/15530#discussion_r3005257414


##########
aws/src/main/java/org/apache/iceberg/aws/glue/GlueTableOperations.java:
##########
@@ -350,6 +350,14 @@ void persistGlueTable(
     }
   }
 
+  private static boolean isDeterministicGlueFailure(RuntimeException 
exception) {
+    return exception instanceof ConcurrentModificationException
+        || exception instanceof 
software.amazon.awssdk.services.glue.model.AlreadyExistsException
+        || exception instanceof EntityNotFoundException
+        || exception instanceof AccessDeniedException
+        || exception instanceof 
software.amazon.awssdk.services.glue.model.ValidationException;
+  }

Review Comment:
   Renamed it to `isKnownGlueCommitFailure` and added some java docs for each



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to