emkornfield commented on code in PR #2288:
URL: https://github.com/apache/iceberg-rust/pull/2288#discussion_r3012424232
##########
crates/iceberg/src/puffin/writer.rs:
##########
@@ -251,7 +251,8 @@ mod tests {
async fn test_write_zstd_compressed_metric_data() {
let temp_dir = TempDir::new().unwrap();
let blobs = vec![blob_0(), blob_1()];
- let blobs_with_compression = blobs_with_compression(blobs.clone(),
CompressionCodec::Zstd);
+ let blobs_with_compression =
+ blobs_with_compression(blobs.clone(),
CompressionCodec::Zstd(None));
Review Comment:
I'm sorry could you elaborate on why you think was incorrect, it appears to
test only code and the actual compress call would use the default value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
