mbutrovich commented on PR #2301: URL: https://github.com/apache/iceberg-rust/pull/2301#issuecomment-4179458140
Most recent changes: 1. **Standalone module** — Moved `coerce_int96_timestamps`, `Int96CoercionVisitor`, and all 5 INT96 tests to `crates/iceberg/src/arrow/int96.rs`. Registered in `mod.rs`. 2. **Concrete types** — Replaced `Self::T`/`Self::U` with `Field`/`ArrowSchema` in all `ArrowSchemaVisitor` method signatures. 3. **Pop in `after_*` methods** — Push in `before_field`/`before_list_element`/`before_map_key`/`before_map_value`, pop in the corresponding `after_*` methods. `primitive`/`struct`/`list`/`map` now peek with `.last()` instead of `.pop()`. 4. **`FieldRef` in field_stack** — Kept `Vec<Field>` for now since the trait passes `&Field`. Added `// TODO(#2310)` comment referencing the tracking issue. Thanks for the patience so far @blackmwk! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
