stevenzwu commented on code in PR #15895: URL: https://github.com/apache/iceberg/pull/15895#discussion_r3047745289
########## api/src/main/java/org/apache/iceberg/catalog/SupportsReferencedBy.java: ########## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.catalog; + +import java.util.List; +import org.apache.iceberg.Table; +import org.apache.iceberg.view.View; + +/** Catalog methods for loading tables and views with a referenced-by view chain. */ +public interface SupportsReferencedBy { Review Comment: For the universal load endpoints for relational objects, I guess we will also need to support `referenced-by`. https://github.com/apache/iceberg/pull/15831/changes#diff-91e43b034980f7feb9d0d959ef4101f26254677c8ba49ad93e1edd31ecd77614 ########## api/src/main/java/org/apache/iceberg/catalog/SessionCatalog.java: ########## @@ -222,6 +196,20 @@ default boolean tableExists(SessionContext context, TableIdentifier ident) { */ Table loadTable(SessionContext context, TableIdentifier ident); + /** + * Load a table with the referenced-by view chain. + * + * @param context session context + * @param ident a table identifier + * @param referencedBy ordered list of view identifiers from outermost to innermost + * @return instance of {@link Table} implementation referred by {@code ident} + * @throws NoSuchTableException if the table does not exist + */ + default Table loadTable( Review Comment: what's the reason for adding the default here? the `SupportsReferencedBy` decorator interface is not extended by this interface. can we just add the proper class that implements this new interface? Maybe only `RESTSessionCatalog` should implement the `SupportsReferencedBy` decorator interface. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
