singhpk234 commented on code in PR #15895:
URL: https://github.com/apache/iceberg/pull/15895#discussion_r3052283047
##########
api/src/main/java/org/apache/iceberg/catalog/SessionCatalog.java:
##########
@@ -222,6 +196,20 @@ default boolean tableExists(SessionContext context,
TableIdentifier ident) {
*/
Table loadTable(SessionContext context, TableIdentifier ident);
+ /**
+ * Load a table with the referenced-by view chain.
+ *
+ * @param context session context
+ * @param ident a table identifier
+ * @param referencedBy ordered list of view identifiers from outermost to
innermost
+ * @return instance of {@link Table} implementation referred by {@code ident}
+ * @throws NoSuchTableException if the table does not exist
+ */
+ default Table loadTable(
Review Comment:
I had that earlier version :
https://github.com/apache/iceberg/commit/e597a1fcd7464b08ca1ba66697bb53553a1249b8#diff-93c6a4d20e7c7d3a8e9b90cac139da020d6a75138c2a5718941a4c4e7b9d8217R198-R210
forgot to update the description :(, wow agents caught that, thats pretty
cool !
Then i went backwards as in this scenario if we let referencedBy skip then
its felt a bit incorrect as i am swallowing the intent of the api, throwing
unsupported exception would better prompt the user for this is what i think,
please let me know you thoughts considering above ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
