rymurr commented on pull request #1825: URL: https://github.com/apache/iceberg/pull/1825#issuecomment-737200894
> Too crazy. Hehehe thanks Ryan. To be fair though the current impl doesn't parse confusing timestamps well. I think the correct impl would be to parse both commit time and passed timestamps into `ZonedDateTime` then write as String in ISO format. Comparing those with prefix matching would then make sense. However I think that may be overkill at this time as the round up mechanism in this PR will satisfy the vast majority of use cases. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
