rdblue commented on a change in pull request #1825:
URL: https://github.com/apache/iceberg/pull/1825#discussion_r533577566
##########
File path: nessie/src/main/java/org/apache/iceberg/nessie/TableReference.java
##########
@@ -83,12 +95,49 @@ public static TableReference parse(String path) {
}
if (path.contains("#")) {
- throw new IllegalArgumentException("Invalid table name:" +
- " # is not allowed (reference by timestamp is not supported)");
+ String[] tableTimestamp = path.split("#");
+ TableIdentifier identifier = TableIdentifier.parse(tableTimestamp[0]);
+ return new TableReference(identifier, parseTimestamp(tableTimestamp[1]),
null);
}
TableIdentifier identifier = TableIdentifier.parse(path);
return new TableReference(identifier, null, null);
}
+
+ private enum FormatOptions {
+ DATE_TIME(DateTimeFormatter.ISO_DATE_TIME, Instant::from),
+ LOCAL_DATE_TIME(DateTimeFormatter.ISO_LOCAL_DATE_TIME, t ->
LocalDateTime.from(t).atZone(UTC).toInstant()),
+ LOCAL_DATE(DateTimeFormatter.ISO_LOCAL_DATE, t ->
LocalDate.from(t).atStartOfDay(UTC).toInstant());
Review comment:
I'm fine changing this to 23:59:59, but there is also a good argument
that it is ambiguous and should be left out. Up to you guys whether you want to
do that or not. Sounds like @jacques-n is in favor of the prefix matching
behavior.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
