sqd commented on code in PR #15433:
URL: https://github.com/apache/iceberg/pull/15433#discussion_r3087694992
##########
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicRecordProcessor.java:
##########
@@ -159,33 +174,37 @@ public void collect(DynamicRecord data) {
}
} else {
emit(
- collector,
data,
foundSchema.resolvedTableSchema(),
foundSchema.recordConverter(),
- foundSpec);
+ foundSpec,
+ isForward);
}
}
private void emit(
- Collector<DynamicRecordInternal> out,
DynamicRecord data,
Schema schema,
DataConverter recordConverter,
- PartitionSpec spec) {
+ PartitionSpec spec,
+ boolean forward) {
RowData rowData = (RowData) recordConverter.convert(data.rowData());
- int writerKey = hashKeyGenerator.generateKey(data, schema, spec, rowData);
- String tableName = data.tableIdentifier().toString();
- out.collect(
+ int writerKey = forward ? 0 : hashKeyGenerator.generateKey(data, schema,
spec, rowData);
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
