rdblue commented on a change in pull request #1843:
URL: https://github.com/apache/iceberg/pull/1843#discussion_r536374139
##########
File path: spark3/src/main/java/org/apache/iceberg/spark/SparkCatalog.java
##########
@@ -132,10 +134,17 @@ protected TableIdentifier buildIdentifier(Identifier
identifier) {
return TableIdentifier.of(Namespace.of(identifier.namespace()),
identifier.name());
}
+ private String[] currentNamespace() {
+ return
SparkSession.active().sessionState().catalogManager().currentNamespace();
Review comment:
If this uses a session, then it should be identified when the catalog is
created and stored as an instance field. Catalogs are specific to a SQL
session, so they should not use the active session except for in
initialization. After that, the same session should always be used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
