rymurr commented on a change in pull request #1843:
URL: https://github.com/apache/iceberg/pull/1843#discussion_r536633817
##########
File path: spark3/src/main/java/org/apache/iceberg/spark/SparkCatalog.java
##########
@@ -132,10 +134,17 @@ protected TableIdentifier buildIdentifier(Identifier
identifier) {
return TableIdentifier.of(Namespace.of(identifier.namespace()),
identifier.name());
}
+ private String[] currentNamespace() {
+ return
SparkSession.active().sessionState().catalogManager().currentNamespace();
Review comment:
fixed. Just for my learning why is it ok to get hadoop config from
active session but not the current namespace? I have been following the
commonly used `SparkSession.active().sessionState().newHadoopConf()` pattern
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
