yyanyy commented on a change in pull request #1857:
URL: https://github.com/apache/iceberg/pull/1857#discussion_r536430266
##########
File path: spark3/src/test/java/org/apache/iceberg/spark/sql/TestSelect.java
##########
@@ -49,8 +49,8 @@ public TestSelect(String catalogName, String implementation,
Map<String, String>
Review comment:
Yeah I actually also spent some time on this but wasn't able to find a
good place to add in spark2, and later gave up thinking that the added logic
was relatively simple anyway. To me `TestReadProjection` is more about testing
projection which is not what we are doing. I guess I'll create a `TestSelect`
in spark3 test suite and duplicate this class then.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
