rdblue commented on a change in pull request #1857:
URL: https://github.com/apache/iceberg/pull/1857#discussion_r536927754
##########
File path: spark2/src/main/java/org/apache/iceberg/spark/SparkFilters.java
##########
@@ -177,4 +179,13 @@ private static Object convertLiteral(Object value) {
}
return value;
}
+
+ private static Expression handleEqual(String attribute, Object value) {
+ Object literal = convertLiteral(value);
Review comment:
This should be moved into the `else` block because literal should not
allow creating a `NaN` literal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]