rdblue commented on a change in pull request #1843:
URL: https://github.com/apache/iceberg/pull/1843#discussion_r536931130
##########
File path: spark3/src/main/java/org/apache/iceberg/spark/SparkCatalog.java
##########
@@ -257,6 +317,7 @@ public boolean dropTable(Identifier ident) {
@Override
public void renameTable(Identifier from, Identifier to) throws
NoSuchTableException, TableAlreadyExistsException {
try {
+ // can't rename hadoop tables
Review comment:
I think this should have a method like `checkNotPathIdentifier` that
throws an IllegalArgumentException if a `PathIdentifier` is passed, so that we
can ensure that they aren't passed to methods that don't support paths.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
