blackmwk commented on PR #2395: URL: https://github.com/apache/iceberg-rust/pull/2395#issuecomment-4395805020
> The Java example gives us historical background on the last-updated-ms isn't being used for ordering validation but is an informative field so long as the clock skew only causes a new update to land within 1 minute less than the previous update. I think we keep the test as its not wrong and after my research yesterday I think the <= assertion makes the test stronger. I agree with following java's behavior to make the `last-updated-ms` field more informative. But this is what this pr is doing. This pr is fixing a check in ut, not at runtime. What actually should be done is to add check at runtime, but maybe we should open another pr for it. For the sake of this pr, we should simply remove the check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
