dramaticlly commented on code in PR #16263:
URL: https://github.com/apache/iceberg/pull/16263#discussion_r3221858328


##########
core/src/test/java/org/apache/iceberg/TestRowLineageAssignment.java:
##########
@@ -781,6 +781,22 @@ public void 
testUpgradeAssignmentWithManifestCompaction(@TempDir File altLocatio
         FILE_C.recordCount() + FILE_B.recordCount());
   }
 
+  @Test
+  public void testRewritePreservesExistingFileFirstRowIds() {
+    table.newAppend().appendFile(FILE_A).appendFile(FILE_B).commit();
+    // FILE_A→0, FILE_B→125; nextRowId=225

Review Comment:
   We ran into this in the past as well, If I understand this correctly, this 
force trigger the manifest merge at the snapshot commit time wher 
ManifestMergeManager kick in to reads this manifest to merge
   it with existing manifests by constructs a `ManifestReader` with 
`firstRowId=null`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to