stevenzwu commented on code in PR #16263:
URL: https://github.com/apache/iceberg/pull/16263#discussion_r3222295255
##########
core/src/main/java/org/apache/iceberg/ManifestReader.java:
##########
@@ -416,13 +429,17 @@ public ManifestEntry<F> apply(ManifestEntry<F> entry) {
return entry;
}
};
+ } else if (!committed) {
+ // Preserve the entry with its firstRowId
+ // as this is an uncommitted manifest which may have already assigned
row IDs (e.g. for
+ // EXISTING entries)
+ return Function.identity();
} else {
- // data file's first_row_id is null when the manifest's first_row_id is
null
+ // committed pre-v3 manifest with a null manifest-level firstRowId
Review Comment:
for pre-v3 manifest files, shouldn't data file's first_row_id be null
anyway? that means `identity` also works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
