joyhaldar commented on code in PR #16097:
URL: https://github.com/apache/iceberg/pull/16097#discussion_r3234831943
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/data/FlinkParquetReaders.java:
##########
@@ -311,6 +311,12 @@ public Optional<ParquetValueReader<?>> visit(
LogicalTypeAnnotation.BsonLogicalTypeAnnotation bsonLogicalType) {
return Optional.of(new ParquetValueReaders.ByteArrayReader(desc));
}
+
+ @Override
+ public Optional<ParquetValueReader<?>> visit(
+ LogicalTypeAnnotation.UUIDLogicalTypeAnnotation uuidLogicalType) {
+ return Optional.of(new ParquetValueReaders.ByteArrayReader(desc));
Review Comment:
Flink doesn't have a `UUID` type, but the existing
[TypeToFlinkType](https://github.com/apache/iceberg/blob/main/flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/TypeToFlinkType.java#L136-L138)
already maps `Iceberg UUID` to `Flink BINARY(16)`, and Flink stores `BINARY`
as `byte[]` in
[RowData](https://github.com/apache/flink/blob/7fc6ca1d19da583fb49c6f73726fc20611d8366a/flink-table/flink-table-common/src/main/java/org/apache/flink/table/data/RowData.java#L76).
So the Parquet reader has to return `byte[]` to fit IIUC.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
