joyhaldar commented on code in PR #16097:
URL: https://github.com/apache/iceberg/pull/16097#discussion_r3234933404
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/FlinkSink.java:
##########
@@ -732,9 +732,8 @@ private DataStream<RowData> distributeDataStream(
@Deprecated
static RowType toFlinkRowType(Schema schema, TableSchema requestedSchema) {
if (requestedSchema != null) {
- // Convert the flink schema to iceberg schema firstly, then reassign ids
to match the existing
- // iceberg schema.
- Schema writeSchema =
TypeUtil.reassignIds(FlinkSchemaUtil.convert(requestedSchema), schema);
Review Comment:
Not removed, just moved inside [FlinkSchemaUtil.convert(schema,
requestedSchema)](https://github.com/apache/iceberg/blob/e57247b55a737cfc3702949181b3a2a3d10174b2/flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/FlinkSchemaUtil.java#L180),
which does
[reassignIds](https://github.com/apache/iceberg/blob/e57247b55a737cfc3702949181b3a2a3d10174b2/flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/FlinkSchemaUtil.java#L184)
and
[FlinkFixupTypes.fixup](https://github.com/apache/iceberg/blob/e57247b55a737cfc3702949181b3a2a3d10174b2/flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/FlinkSchemaUtil.java#L189).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
