aokolnychyi commented on a change in pull request #1890:
URL: https://github.com/apache/iceberg/pull/1890#discussion_r538625798
##########
File path:
spark3/src/main/java/org/apache/iceberg/spark/procedures/ExpireSnapshotsProcedure.java
##########
@@ -77,12 +76,11 @@ public StructType outputType() {
@Override
public InternalRow[] call(InternalRow args) {
- String namespace = args.getString(0);
- String tableName = args.getString(1);
- Long olderThanMillis = args.isNullAt(2) ? null :
DateTimeUtils.toMillis(args.getLong(2));
- Integer retainLastNum = args.isNullAt(3) ? null : args.getInt(3);
+ String tableName = args.getString(0);
Review comment:
I think we better call our variables `tableIdent` rather than
`tableName` now. I think we can keep the parameter name as `table`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
