aokolnychyi commented on a change in pull request #1890:
URL: https://github.com/apache/iceberg/pull/1890#discussion_r538631234
##########
File path: spark3/src/main/java/org/apache/iceberg/spark/Spark3Util.java
##########
@@ -605,31 +605,41 @@ private static String
sqlString(org.apache.iceberg.expressions.Literal<?> lit) {
}
public static CatalogAndIdentifier catalogAndIdentifier(SparkSession spark,
String name) throws ParseException {
+ return catalogAndIdentifier(spark, name,
spark.sessionState().catalogManager().currentCatalog());
+ }
+
+ public static CatalogAndIdentifier catalogAndIdentifier(SparkSession spark,
String name,
+ CatalogPlugin
fallBackCatalog) throws ParseException {
Review comment:
Shall we call it `defaultCatalog`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
