hsiang-c commented on code in PR #2453:
URL: https://github.com/apache/iceberg-rust/pull/2453#discussion_r3244705903
##########
crates/iceberg/src/table.rs:
##########
@@ -33,6 +35,7 @@ pub struct TableBuilder {
metadata_location: Option<String>,
metadata: Option<TableMetadataRef>,
identifier: Option<TableIdent>,
+ kms_client: Option<Arc<dyn KeyManagementClient>>,
Review Comment:
Thanks for working on the encryption support @xanderbailey, this is really
great.
I think `TableMetadata::table_properties` has all the information we need to
construct either a `KeyManagementClient` or a `EncryptionManager`. Do you think
we could build them as part of the builder instead of passing
`KeyManagementClient` in the API?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
