hsiang-c commented on code in PR #2453:
URL: https://github.com/apache/iceberg-rust/pull/2453#discussion_r3263412103
##########
crates/iceberg/src/spec/table_properties.rs:
##########
@@ -226,6 +231,15 @@ impl TableProperties {
pub const PROPERTY_GC_ENABLED: &str = "gc.enabled";
/// Default value for gc.enabled
pub const PROPERTY_GC_ENABLED_DEFAULT: bool = true;
+
+ /// Property key for the master key id used to encrypt the table's manifest
+ /// list and data files as defined in
https://iceberg.apache.org/docs/nightly/encryption/.
+ pub const PROPERTY_ENCRYPTION_KEY_ID: &str = "encryption.key-id";
+
+ /// Property key for the encryption data encryption key (DEK) length in
bytes.
+ pub const PROPERTY_ENCRYPTION_DATA_KEY_LENGTH: &str =
"encryption.data-key-length";
Review Comment:
Thanks for adding it. I think I can get rid of the additional argument for
data key length In introduced in
https://github.com/apache/iceberg-rust/pull/2466
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
