plusplusjiajia commented on code in PR #616:
URL: https://github.com/apache/iceberg-cpp/pull/616#discussion_r3253844670
##########
.github/workflows/cpp-linter.yml:
##########
@@ -38,13 +38,25 @@ jobs:
- name: Install dependencies
shell: bash
run: sudo apt-get update && sudo apt-get install -y
libcurl4-openssl-dev
+ - name: Cache vcpkg packages
+ uses: actions/cache@v4
+ id: vcpkg-cache
+ with:
+ path: /usr/local/share/vcpkg/installed
+ key: vcpkg-x64-linux-aws-sdk-cpp-core-${{
hashFiles('.github/workflows/cpp-linter.yml') }}
+ - name: Install AWS SDK via vcpkg
+ if: steps.vcpkg-cache.outputs.cache-hit != 'true'
+ shell: bash
+ run: vcpkg install aws-sdk-cpp[core]:x64-linux
- name: Run build
env:
CC: gcc-14
CXX: g++-14
run: |
mkdir build && cd build
- cmake .. -G Ninja -DCMAKE_EXPORT_COMPILE_COMMANDS=ON
+ cmake .. -G Ninja -DCMAKE_EXPORT_COMPILE_COMMANDS=ON \
+ -DICEBERG_BUILD_SIGV4=ON \
Review Comment:
@wgtmac Thanks for the suggestion — reverted cpp-linter.yml to the upstream
pattern (no AWS SDK install) and added a dedicated sigv4_test.yml that installs
aws-cpp-sdk-core via vcpkg and exercises the SigV4 build unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
