plusplusjiajia commented on code in PR #616:
URL: https://github.com/apache/iceberg-cpp/pull/616#discussion_r3253851958
##########
src/iceberg/catalog/rest/CMakeLists.txt:
##########
@@ -63,4 +74,12 @@ add_iceberg_lib(iceberg_rest
SHARED_INSTALL_INTERFACE_LIBS
${ICEBERG_REST_SHARED_INSTALL_INTERFACE_LIBS})
+if(ICEBERG_BUILD_SIGV4)
+ foreach(LIB iceberg_rest_static iceberg_rest_shared)
+ if(TARGET ${LIB})
+ target_compile_definitions(${LIB} PUBLIC ICEBERG_BUILD_SIGV4)
+ endif()
+ endforeach()
+endif()
+
iceberg_install_all_headers(iceberg/catalog/rest)
Review Comment:
@wgtmac Thanks for catching this! Renamed sigv4_auth_manager.h →
sigv4_auth_manager_internal.h.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
