stevenzwu commented on code in PR #15630: URL: https://github.com/apache/iceberg/pull/15630#discussion_r3252350735
########## format/spec.md: ########## @@ -134,8 +149,10 @@ Tables do not require rename, except for tables that use atomic rename to implem * **Manifest** -- A file that lists data or delete files; a subset of a snapshot. * **Data file** -- A file that contains rows of a table. * **Delete file** -- A file that encodes rows of a table that are deleted by position or data values. +* **Absolute path** -- A path string that includes a [URI](https://datatracker.ietf.org/doc/html/rfc3986#section-3.1) scheme and can be used directly. +* **Relative path** -- A path string without a URI scheme that must be [resolved](#path-resolution) against the table location. Review Comment: In the end, every comment reflects my opinion because I carefully reviewed, edited, or dropped the comments before publishing. I just checked the current table spec. There is only one mentioning of fully qualified for the data file fields, where the wording matching the definition of absolute path. ``` 143 referenced_data_file | string | Fully qualified location (URI with FS scheme) of a data file that all deletes reference ``` I was saying that it was not explicitly defined in the terms list. does it make sense to define the term of fully qualified path in the bullet list formally? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
