rdblue commented on code in PR #15630: URL: https://github.com/apache/iceberg/pull/15630#discussion_r3262166090
########## format/spec.md: ########## @@ -134,8 +149,10 @@ Tables do not require rename, except for tables that use atomic rename to implem * **Manifest** -- A file that lists data or delete files; a subset of a snapshot. * **Data file** -- A file that contains rows of a table. * **Delete file** -- A file that encodes rows of a table that are deleted by position or data values. +* **Absolute path** -- A path string that includes a [URI](https://datatracker.ietf.org/doc/html/rfc3986#section-3.1) scheme and can be used directly. +* **Relative path** -- A path string without a URI scheme that must be [resolved](#path-resolution) against the table location. Review Comment: I agree with Dan here. We don't want to introduce more definitions for old versions. We should carry them forward and let them be interpreted as they were before. The only place where this matters is the scheme, which was specifically called out as required. It was never optional, but we know that paths were sometimes created without it. The note about supplying a scheme for v3 and earlier isn't changing the requirement, it is stating that if you produce paths without a scheme when reading, it's going to break in v4 because we are more strict and would decide to handle paths without a scheme as relative. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
