rdblue commented on a change in pull request #1888:
URL: https://github.com/apache/iceberg/pull/1888#discussion_r538814913
##########
File path: core/src/main/java/org/apache/iceberg/io/BaseTaskWriter.java
##########
@@ -75,6 +79,113 @@ public WriteResult complete() throws IOException {
.build();
}
+ /**
+ * Base delta writer to write both insert records and equality-deletes.
+ */
+ protected abstract class BaseDeltaWriter implements Closeable {
+ private RollingFileWriter dataWriter;
+ private RollingEqDeleteWriter eqDeleteWriter;
+ private SortedPosDeleteWriter<T> posDeleteWriter;
+ private StructLikeMap<PathOffset> insertedRowMap;
+
+ public BaseDeltaWriter(PartitionKey partition, Schema eqDeleteSchema) {
+ Preconditions.checkNotNull(eqDeleteSchema, "equality-delete schema could
not be null.");
+
+ this.dataWriter = new RollingFileWriter(partition);
+
+ this.eqDeleteWriter = new RollingEqDeleteWriter(partition);
+ this.insertedRowMap = StructLikeMap.create(eqDeleteSchema.asStruct());
+
+ this.posDeleteWriter = new SortedPosDeleteWriter<>(appenderFactory,
fileFactory, format, partition);
+ }
+
+ /**
+ * Make the generic data could be read as a {@link StructLike}.
+ */
+ protected abstract StructLike asStructLike(T data);
+
+ protected abstract StructLike asCopiedKey(T row);
+
+ public void write(T row) throws IOException {
+ PathOffset pathOffset = PathOffset.of(dataWriter.currentPath(),
dataWriter.currentRows());
+
+ StructLike copiedKey = asCopiedKey(row);
+ // Adding a pos-delete to replace the old filePos.
+ PathOffset previous = insertedRowMap.put(copiedKey, pathOffset);
+ if (previous != null) {
+ // TODO attach the previous row if has a positional-delete row schema
in appender factory.
+ posDeleteWriter.delete(previous.path, previous.rowOffset, null);
+ }
+
+ dataWriter.write(row);
+ }
+
+ /**
+ * Delete the rows with the given key.
+ *
+ * @param key is the projected values which could be write to eq-delete
file directly.
+ */
+ public void delete(T key) throws IOException {
Review comment:
From the tests, I see that this can be used when the deleted row won't
be passed. But I don't think this leaves an option for writing an entire row to
the delete file and using a subset of its columns for the delete. This assumes
that whatever struct is passed here is the entire delete key.
To support both use cases (writing an already projected key and writing a
full row and projecting), I think we should have two methods: `deleteKey` and
`delete`. That way both are supported. We would also need a test for passing
the full row to the delete file, but deleting by key.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
