openinx commented on a change in pull request #1888:
URL: https://github.com/apache/iceberg/pull/1888#discussion_r539052545
##########
File path: core/src/main/java/org/apache/iceberg/io/BaseTaskWriter.java
##########
@@ -75,6 +79,113 @@ public WriteResult complete() throws IOException {
.build();
}
+ /**
+ * Base delta writer to write both insert records and equality-deletes.
+ */
+ protected abstract class BaseDeltaWriter implements Closeable {
+ private RollingFileWriter dataWriter;
+ private RollingEqDeleteWriter eqDeleteWriter;
+ private SortedPosDeleteWriter<T> posDeleteWriter;
+ private StructLikeMap<PathOffset> insertedRowMap;
+
+ public BaseDeltaWriter(PartitionKey partition, Schema eqDeleteSchema) {
+ Preconditions.checkNotNull(eqDeleteSchema, "equality-delete schema could
not be null.");
+
+ this.dataWriter = new RollingFileWriter(partition);
+
+ this.eqDeleteWriter = new RollingEqDeleteWriter(partition);
+ this.insertedRowMap = StructLikeMap.create(eqDeleteSchema.asStruct());
+
+ this.posDeleteWriter = new SortedPosDeleteWriter<>(appenderFactory,
fileFactory, format, partition);
+ }
+
+ /**
+ * Make the generic data could be read as a {@link StructLike}.
+ */
+ protected abstract StructLike asStructLike(T data);
+
+ protected abstract StructLike asCopiedKey(T row);
+
+ public void write(T row) throws IOException {
+ PathOffset pathOffset = PathOffset.of(dataWriter.currentPath(),
dataWriter.currentRows());
+
+ StructLike copiedKey = asCopiedKey(row);
+ // Adding a pos-delete to replace the old filePos.
+ PathOffset previous = insertedRowMap.put(copiedKey, pathOffset);
+ if (previous != null) {
+ // TODO attach the previous row if has a positional-delete row schema
in appender factory.
+ posDeleteWriter.delete(previous.path, previous.rowOffset, null);
+ }
+
+ dataWriter.write(row);
+ }
+
+ /**
+ * Delete the rows with the given key.
+ *
+ * @param key is the projected values which could be write to eq-delete
file directly.
+ */
+ public void delete(T key) throws IOException {
Review comment:
I agreed that it's better to provide a `delete(T row)` method which can
accept an entire row to write eq-delete file. Because it's possible that have a
table with (a,b,c,d) columns, the equality fields are `(a,c)` columns, while
someone want to write the `(a,b,c,d)` values into eq-delete file.
The problem is: how could we project the generic data type `T` to match the
expected `eqDeleteRowSchema` (so that the eqDeleteWriter could write the
correct column values) ? Sounds like we will need to provide an extra
abstracted method to accomplish that generic projection ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
