happydave1 commented on code in PR #984:
URL: https://github.com/apache/iceberg-go/pull/984#discussion_r3261855171
##########
exprs.go:
##########
@@ -450,6 +450,8 @@ func createBoundRef(field NestedField, acc accessor)
BoundReference {
return &boundRef[Decimal]{field: field, acc: acc}
case UUIDType:
return &boundRef[uuid.UUID]{field: field, acc: acc}
+ case GeographyType, GeometryType:
+ return &boundRef[[]byte]{field: field, acc: acc}
Review Comment:
Good catch, thanks!
I took option A - it made the most sense to me. Now the downstream dispatch
sites should handle the geo-types more consistently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]