happydave1 commented on PR #984: URL: https://github.com/apache/iceberg-go/pull/984#issuecomment-4482094712
Thanks for the clear and precise review last round @laskoviymishka. Good catches on all the issues presented. I have added `Geography` and `Geometry` cases to all 4 locations mentioned in the dialogue around the `createBoundRef` issue. I have also fixed the canonicalization issue for both `GeographyTypeOf` and `GeometryTypeOf` - this was a good catch since we handle `algorithm` with a `strings.TrimSpace` as well in `toGeoEdgeInterpolation`. Finally, I fixed the Substrait one-liner by making `VisitGeometry` a multi-line function. This will make it consistent with `VisitGeography`. Please let me know what you think, any feedback would be greatly appreciated. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
