RussellSpitzer commented on a change in pull request #1890:
URL: https://github.com/apache/iceberg/pull/1890#discussion_r538829879
##########
File path:
spark3/src/main/java/org/apache/iceberg/spark/procedures/BaseProcedure.java
##########
@@ -48,20 +47,18 @@ protected BaseProcedure(TableCatalog tableCatalog) {
this.tableCatalog = tableCatalog;
}
- protected <T> T modifyIcebergTable(String namespace, String tableName,
Function<org.apache.iceberg.Table, T> func) {
- return execute(namespace, tableName, true, func);
+ protected <T> T modifyIcebergTable(String identifierAsString,
Function<org.apache.iceberg.Table, T> func) {
+ return execute(identifierAsString, true, func);
}
- protected <T> T withIcebergTable(String namespace, String tableName,
Function<org.apache.iceberg.Table, T> func) {
- return execute(namespace, tableName, false, func);
+ protected <T> T withIcebergTable(String identifierAsString,
Function<org.apache.iceberg.Table, T> func) {
+ return execute(identifierAsString, false, func);
}
- private <T> T execute(String namespace, String tableName, boolean
refreshSparkCache,
+ private <T> T execute(String identifierAsString, boolean refreshSparkCache,
Function<org.apache.iceberg.Table, T> func) {
- Preconditions.checkArgument(namespace != null && !namespace.isEmpty(),
"Namespace cannot be empty");
Review comment:
There is a precondition on the null/empty issue in "toIdentifier"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
