aokolnychyi commented on a change in pull request #1890:
URL: https://github.com/apache/iceberg/pull/1890#discussion_r539122717
##########
File path:
spark3/src/main/java/org/apache/iceberg/spark/procedures/BaseProcedure.java
##########
@@ -48,20 +48,17 @@ protected BaseProcedure(TableCatalog tableCatalog) {
this.tableCatalog = tableCatalog;
}
- protected <T> T modifyIcebergTable(String namespace, String tableName,
Function<org.apache.iceberg.Table, T> func) {
- return execute(namespace, tableName, true, func);
+ protected <T> T modifyIcebergTable(Identifier ident,
Function<org.apache.iceberg.Table, T> func) {
+ return execute(ident, true, func);
}
- protected <T> T withIcebergTable(String namespace, String tableName,
Function<org.apache.iceberg.Table, T> func) {
- return execute(namespace, tableName, false, func);
+ protected <T> T withIcebergTable(Identifier ident,
Function<org.apache.iceberg.Table, T> func) {
+ return execute(ident, false, func);
}
- private <T> T execute(String namespace, String tableName, boolean
refreshSparkCache,
+ private <T> T execute(Identifier ident, boolean refreshSparkCache,
Review comment:
nit: can fit on one line now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
