kevinjqliu commented on code in PR #915:
URL: https://github.com/apache/iceberg-go/pull/915#discussion_r3264152831
##########
partitions.go:
##########
@@ -499,6 +499,15 @@ func (ps *PartitionSpec) PartitionType(schema *Schema)
*StructType {
continue
}
resultType := field.Transform.ResultType(sourceType)
+ // DayTransform.ResultType returns Int32 (days since epoch),
but the
Review Comment:
i would suggest changing the `DayTransform`'s `ResultType` to
`PrimitiveTypes.Date` instead
https://github.com/apache/iceberg-go/blob/1a446112ccb7a3453853ab5c5f10c7aa24cfb945/transforms.go#L792
so iceberg-go is better aligned with other implementations (see
https://github.com/apache/iceberg/issues/16414)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
