zeroshade commented on code in PR #915:
URL: https://github.com/apache/iceberg-go/pull/915#discussion_r3270138838
##########
partitions.go:
##########
@@ -499,6 +499,15 @@ func (ps *PartitionSpec) PartitionType(schema *Schema)
*StructType {
continue
}
resultType := field.Transform.ResultType(sourceType)
+ // DayTransform.ResultType returns Int32 (days since epoch),
but the
Review Comment:
agreed, let's get that updated first before we merge this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
