kevinjqliu opened a new pull request, #16497:
URL: https://github.com/apache/iceberg/pull/16497

   Follow-up to #16496. The previous PR used `os.symlink` to create 
`docs/1.11.0/ → docs/latest/` in the build output. This worked locally (`mkdocs 
serve` follows symlinks) but failed in production because `ghp-import` commits 
symlinks as git symlink objects (mode `120000`), which ASF's static hosting 
does not resolve, resulting in a 404.
   
   This fix replaces the symlink with `shutil.copytree` using `os.link` (hard 
links). Hard links are indistinguishable from regular files at the filesystem 
level, so git commits them as normal file content. This makes 
`https://iceberg.apache.org/docs/1.11.0/` work while using zero additional disk 
space locally.
   
   Also adds graceful error handling so the hook cannot crash the build — it 
falls back to a regular copy if hard links aren't supported, and logs a warning 
instead of failing if anything goes wrong.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to