kevinjqliu commented on code in PR #16497:
URL: https://github.com/apache/iceberg/pull/16497#discussion_r3293400797
##########
site/dev/common.sh:
##########
@@ -103,33 +103,16 @@ get_latest_version () {
echo "${latest_version}"
}
-# Creates a 'latest' version of the documentation based on a specified
ICEBERG_VERSION.
+# Sets up the 'latest' javadoc symlink pointing at ICEBERG_VERSION.
# Arguments:
-# $1: ICEBERG_VERSION - The version number of the documentation to be
treated as the latest.
-create_latest () {
+# $1: ICEBERG_VERSION - The version number to expose as 'latest'.
+create_latest_javadoc_symlink () {
Review Comment:
this is changed because we no longer create `versioned-docs/latest/` folder,
its done via post build hook instead
##########
site/hooks/version_alias.py:
##########
@@ -18,34 +18,32 @@
"""
MkDocs hook: version URL alias.
-Creates a symlink so that /docs/<icebergVersion>/ resolves to /docs/latest/.
-This allows version-specific URLs (e.g. /docs/1.11.0/) to work without
-duplicating the navigation entry for the latest version.
+Creates docs/<icebergVersion>/ from the built docs/latest/ output so that the
Review Comment:
made the change to the other way around. agreed that it makes more sense to
make `latest` an alias to the current version.
symlink doesnt work apparently, #16496 was using symlink. `mkdocs gh-deploy`
does not follow symlink, so we have to make a copy post build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
