pvary commented on a change in pull request #1850:
URL: https://github.com/apache/iceberg/pull/1850#discussion_r539376787
##########
File path:
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java
##########
@@ -366,20 +370,27 @@ static void validateTableIsIceberg(Table table, String
fullName) {
* The decision is made like this:
* <ol>
* <li>Table property value {@link TableProperties#ENGINE_HIVE_ENABLED}
- * <li>If the table property is not set then check the hive-site.xml
property value
+ * <li>If the table property is not set then check hive metastore
TABLE_PARAMS value
* {@link ConfigProperties#ENGINE_HIVE_ENABLED}
+ * <li>If the table property is not set and hive metastore TABLE_PARAMS is
not set
+ * then check the hive-site.xml property value{@link
ConfigProperties#ENGINE_HIVE_ENABLED}
* <li>If none of the above is enabled then use the default value {@link
TableProperties#ENGINE_HIVE_ENABLED_DEFAULT}
* </ol>
* @param metadata Table metadata to use
+ * @param parameters Hive table parameters to use
* @param conf The hive configuration to use
* @return if the hive engine related values should be enabled or not
*/
- private static boolean hiveEngineEnabled(TableMetadata metadata,
Configuration conf) {
+ private static boolean hiveEngineEnabled(TableMetadata metadata, Map<String,
String> parameters, Configuration conf) {
Review comment:
@zhangdove: To be honest, I am not sure I have understand everything you
have proposed. There are several alternative ways to enable Hive configuration
on the tables ATM:
1. Global configuration: Here we have to set
`iceberg.engine.hive.enabled=true` in the hive-site.xml or other global config
2. Local configuration: Every client making changes to the table should set
`iceberg.engine.hive.enabled=true` in the configuration they are using
3. Table configuration: The table property (`engine.hive.enabled`) should be
set directly on the table.
Would this be appropriate for you?
Thanks,
Peter
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
