pvary commented on pull request #1850: URL: https://github.com/apache/iceberg/pull/1850#issuecomment-742434651
> > @zhangdove: Thanks for bringing this up, and confirming the solution! @massdosage: do we want to clarify this in the doc? I think we should mention that `!everyone!` modifying the table should have the `iceberg.engine.hive.enabled` set if the `engine.hive.enabled` Iceberg table property is not set. What do you think? > > Well, at https://iceberg.apache.org/hive/ -> "Using Hive Catalog" -> "Hive Configuration" and "Table Property Configuration" we already cover that don't we? We write that there: > The value iceberg.engine.hive.enabled needs to be set to true and added to the Hive configuration file on the classpath of the application creating the table. Maybe we should extend it like this: > The value iceberg.engine.hive.enabled needs to be set to true and added to the Hive configuration file on the classpath of the application creating or modifying (alter/insert etc) the table. Would this be more clear? Asking you not only as a fellow Iceberg developer but as a native English speaker as well 😃 Thanks, Peter ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
