pvary commented on code in PR #16569:
URL: https://github.com/apache/iceberg/pull/16569#discussion_r3311531282
##########
api/src/main/java/org/apache/iceberg/PartitionStatistics.java:
##########
@@ -84,7 +92,11 @@ private static Schema v2Schema(Types.StructType
unifiedPartitionType) {
LAST_UPDATED_SNAPSHOT_ID);
}
- private static Schema v3Schema(Types.StructType unifiedPartitionType) {
+ private static Schema v3WriteSchema(Types.StructType unifiedPartitionType) {
+ return latestSchema(unifiedPartitionType);
+ }
+
+ static Schema latestSchema(Types.StructType unifiedPartitionType) {
Review Comment:
What is this `latestSchema`?
I don't understand based on the name, and it is on a public API. We need
javadoc if we need the method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
