gaborkaszab commented on code in PR #16569:
URL: https://github.com/apache/iceberg/pull/16569#discussion_r3318346457


##########
core/src/test/java/org/apache/iceberg/PartitionStatsHandlerTestBase.java:
##########
@@ -250,6 +252,8 @@ public void testOptionalFieldsWriting() throws Exception {
 
     List<PartitionStatistics> expected = partitionListBuilder.build();
 
+    Integer expectedDVCount = formatVersion > 2 ? 0 : null;

Review Comment:
   @pvary  With this approach reading a missing dv_count will give null in V2 
and zero in V3 and above (optional vs required)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to