rambleraptor commented on code in PR #3418:
URL: https://github.com/apache/iceberg-python/pull/3418#discussion_r3314316445
##########
tests/catalog/test_rest.py:
##########
@@ -2287,6 +2023,71 @@ def test_request_session_with_ssl_client_cert() -> None:
assert "Could not find the TLS certificate file, invalid path:
path_to_client_cert" in str(e.value)
+def test_session_without_connection_config_uses_default_adapter(rest_mock:
Mocker) -> None:
Review Comment:
Can we get a test where we set the retry logic and then see the retries
occur? We should be able to simulate this with mock HTTP calls and then see
that X number of HTTP calls were made afterwards.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
