rahulsmahadev commented on PR #3418: URL: https://github.com/apache/iceberg-python/pull/3418#issuecomment-4664543411
Pushed 6fb87ff addressing the review feedback: - **@Fokko / @rambleraptor**: dropped the urllib3 retry-dict pass-through. The `connection` block now exposes only three explicit options — `timeout`, `retries`, `backoff-factor` — with `status_forcelist` and `allowed_methods` hard-coded internally (transient codes + idempotent verbs), so users can't accidentally swallow non-transient errors or retry non-idempotent writes. - **@rambleraptor (retry test)**: added `test_session_retries_on_transient_5xx_then_succeeds` that uses a real loopback `http.server` (since `requests_mock` replaces the HTTPAdapter and bypasses retry logic). The handler returns three 503s then a 200; the test asserts both that `list_namespaces` succeeds and that the handler saw 4 requests. - **@rambleraptor (lint)**: the three CI mypy errors are fixed — `_RetryTimeoutHTTPAdapter.send` now matches the parent signature, and the `set(allowed_methods)` call guards the `Collection[str] | None` type. PTAL! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
