slfan1989 commented on code in PR #15897: URL: https://github.com/apache/iceberg/pull/15897#discussion_r3316135333
########## kafka-connect/kafka-connect-runtime/runtime-deps.txt: ########## @@ -71,7 +70,7 @@ com.google.re2j:re2j:1.8 com.jcraft:jsch:0.1 com.microsoft.azure:msal4j-persistence-extension:1.3 com.microsoft.azure:msal4j:1.23 -com.sun.xml.bind:jaxb-impl:2.2 +com.sun.istack:istack-commons-runtime:3.0 Review Comment: > why do we need to handle `msal4j-persistence-extension`? Thanks for the question! Initially, I added the `msal4j-persistence-extension` LICENSE entry because it was present in the Kafka Connect runtime classpath and in runtime-deps.txt. Under the current convention, if a dependency is included in the runtime distribution, the LICENSE should be updated accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
