slfan1989 commented on code in PR #15897: URL: https://github.com/apache/iceberg/pull/15897#discussion_r3316154584
########## kafka-connect/kafka-connect-runtime/runtime-deps.txt: ########## @@ -71,7 +70,7 @@ com.google.re2j:re2j:1.8 com.jcraft:jsch:0.1 com.microsoft.azure:msal4j-persistence-extension:1.3 com.microsoft.azure:msal4j:1.23 -com.sun.xml.bind:jaxb-impl:2.2 +com.sun.istack:istack-commons-runtime:3.0 Review Comment: After checking this more closely, it looks like `msal4j-persistence-extension` is only an optional transitive dependency from `azure-identity`, and the current code path here does not use the token cache persistence APIs. So the cleaner fix seems to be excluding it from the runtime dependency, regenerating `runtime-deps.txt`, and removing the corresponding `LICENSE` entries so the `runtime classpath`, `runtime-deps.txt`, and `LICENSE` stay aligned. Does that approach look reasonable to you? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
