RussellSpitzer commented on code in PR #15614:
URL: https://github.com/apache/iceberg/pull/15614#discussion_r3320078765
##########
core/src/main/java/org/apache/iceberg/rest/RESTCatalogProperties.java:
##########
@@ -55,6 +55,19 @@ private RESTCatalogProperties() {}
public static final String TABLE_CACHE_MAX_ENTRIES =
"rest-table-cache.max-entries";
public static final int TABLE_CACHE_MAX_ENTRIES_DEFAULT = 100;
+ /**
+ * Controls whether engines using a REST Catalog should delegate DROP TABLE
PURGE requests to the
+ * catalog instead of performing client-side file deletion.
+ *
+ * <p>When enabled, the engine sends the purge request to the REST catalog,
allowing the catalog
+ * to handle deletion.
+ *
+ * <p>Defaults to false for backward compatibility.
+ */
+ public static final String REST_CATALOG_PURGE = "rest.catalog-purge";
Review Comment:
probably needs to be "rest-catalog-purge" if it lives here. But I don't
think it should be here though still. I think I commented on this before but
Spark is the only user of this property. The only other possible engine we have
to use this is Flink and Flink doesn't let you *not* do delegate the purge to
the catalog. It always sends the purge flag to the catalog.
I think this needs to move either directly into Spark Catalog or into a new
file SparkCatalogProperties.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
