stevenzwu commented on code in PR #16160: URL: https://github.com/apache/iceberg/pull/16160#discussion_r3321077762
########## api/src/main/java/org/apache/iceberg/catalog/CatalogObjectIdentifier.java: ########## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.catalog; + +import java.util.Arrays; +import java.util.function.Predicate; +import java.util.regex.Pattern; +import org.apache.iceberg.relocated.com.google.common.base.Joiner; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; + +/** + * A reference to a catalog object as an ordered list of hierarchical levels (for example, a table, + * view, or namespace). The kind of object is determined by context — the endpoint or a companion + * type discriminator — not by the identifier structure alone. + * + * <p>Mirrors {@link Namespace} structurally; the distinct name signals "any object within a + * catalog" and avoids confusion with a future top-level catalog name. + */ +public class CatalogObjectIdentifier { + private static final Joiner DOT = Joiner.on('.'); + private static final Predicate<String> CONTAINS_NULL_CHARACTER = + Pattern.compile("\u0000", Pattern.UNICODE_CHARACTER_CLASS).asPredicate(); + + public static CatalogObjectIdentifier of(String... levels) { + Preconditions.checkArgument( + null != levels, "Cannot create catalog object identifier from null array"); + Preconditions.checkArgument( + levels.length > 0, "Cannot create catalog object identifier with no levels"); Review Comment: also chatted with Ryan offline. It seems the spec and Java impl don't need to add this check of non-empty array. An empty array can reference the catalog root. Although we don't have a strong use case yet, it is not necessary to prevent it. Catalog server may implement their own validations. With that, I will drop this validation and close the OpenAPI PR #16587 that adds `minItems: 1`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
