mbutrovich commented on code in PR #2188:
URL: https://github.com/apache/iceberg-rust/pull/2188#discussion_r3326703491
##########
crates/iceberg/src/spec/schema/index.rs:
##########
@@ -53,6 +53,10 @@ pub fn index_by_id(r#struct: &StructType) ->
Result<HashMap<i32, NestedFieldRef>
fn primitive(&mut self, _: &PrimitiveType) -> Result<Self::T> {
Ok(())
}
+
+ fn variant(&mut self, _v: &crate::spec::VariantType) ->
Result<Self::T> {
Review Comment:
Applies to `crates/iceberg/src/spec/schema/index.rs:57, 153, 305` and
`crates/iceberg/src/spec/schema/prune_columns.rs:242` and
`crates/catalog/glue/src/schema.rs:186` and
`crates/catalog/hms/src/schema.rs:143`
Minor: `crate::spec::VariantType` inline rather than `use`'d. The codebase
has mixed precedent here (some files use inline FQNs too) so feel free to
ignore, but `use` would match the surrounding files' imports more closely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
